refactor(api): replace gorilla/mux with net/http across agent servers by pgimalac · Pull Request #50380 · DataDog/datadog-agent

pgimalac · 2026-05-05T14:41:33Z

What does this PR do?

Replaces github.com/gorilla/mux (and gorilla/handlers) with the standard library net/http across most of the agent's HTTP servers. Second step in the series to remove gorilla entirely — follow-up to #50275.

Motivation

gorilla/mux has been archived since 2023. Go 1.22+ net/http covers everything we use.

Describe how you validated your changes

CI
Ran a full pipeline to have all e2e tests

dd-octo-sts · 2026-05-05T14:50:29Z

Go Package Import Differences

Baseline: 120c177
Comparison: 50f1712

binary	os	arch	change
heroku-agent	linux	amd64	+1, -0 +github.com/DataDog/datadog-agent/pkg/api/middleware
cluster-agent	linux	amd64	+1, -2 +github.com/DataDog/datadog-agent/pkg/api/middleware -github.com/gorilla/handlers -github.com/gorilla/mux
cluster-agent	linux	arm64	+1, -2 +github.com/DataDog/datadog-agent/pkg/api/middleware -github.com/gorilla/handlers -github.com/gorilla/mux
cluster-agent-cloudfoundry	linux	amd64	+1, -3 +github.com/DataDog/datadog-agent/pkg/api/middleware -github.com/felixge/httpsnoop -github.com/gorilla/handlers -github.com/gorilla/mux
cluster-agent-cloudfoundry	linux	arm64	+1, -3 +github.com/DataDog/datadog-agent/pkg/api/middleware -github.com/felixge/httpsnoop -github.com/gorilla/handlers -github.com/gorilla/mux
dogstatsd	linux	amd64	+0, -1 -github.com/gorilla/mux
dogstatsd	linux	arm64	+0, -1 -github.com/gorilla/mux
process-agent	linux	amd64	+0, -1 -github.com/gorilla/mux
process-agent	linux	arm64	+0, -1 -github.com/gorilla/mux
process-agent	windows	amd64	+0, -1 -github.com/gorilla/mux
process-agent	darwin	amd64	+0, -1 -github.com/gorilla/mux
process-agent	darwin	arm64	+0, -1 -github.com/gorilla/mux
heroku-process-agent	linux	amd64	+0, -1 -github.com/gorilla/mux
security-agent	linux	amd64	+0, -1 -github.com/gorilla/mux
security-agent	linux	arm64	+0, -1 -github.com/gorilla/mux
security-agent	windows	amd64	+0, -1 -github.com/gorilla/mux
host-profiler	linux	amd64	+0, -1 -github.com/gorilla/mux
host-profiler	linux	arm64	+0, -1 -github.com/gorilla/mux
installer	linux	amd64	+1, -1 +github.com/DataDog/datadog-agent/pkg/api/middleware -github.com/gorilla/mux
installer	linux	arm64	+1, -1 +github.com/DataDog/datadog-agent/pkg/api/middleware -github.com/gorilla/mux
installer	windows	amd64	+1, -1 +github.com/DataDog/datadog-agent/pkg/api/middleware -github.com/gorilla/mux
privateactionrunner	linux	amd64	+0, -1 -github.com/gorilla/mux
privateactionrunner	linux	arm64	+0, -1 -github.com/gorilla/mux
privateactionrunner	windows	amd64	+0, -1 -github.com/gorilla/mux
privateactionrunner	darwin	amd64	+0, -1 -github.com/gorilla/mux
privateactionrunner	darwin	arm64	+0, -1 -github.com/gorilla/mux

datadog-prod-us1-5 · 2026-05-05T15:07:24Z

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/datadog-agent | oracle: [21.3.0-xe]

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration.
failed to ping oracle instance: ORA-12514: TNS:listener does not currently know of service requested in connect descriptor

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 34.21%
• Overall Coverage: 50.26% (-0.01%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 50f1712 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-05-06T14:34:46Z

Files inventory check summary

File checks results against ancestor 120c1774:

Results for datadog-agent_7.81.0~devel.git.83.50f1712.pipeline.113925304-1_amd64.deb:

No change detected

dd-octo-sts · 2026-05-06T14:45:14Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 120c177
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	N/A	N/A → 745.060 → 750.800
✅	agent_deb_amd64_fips	N/A	N/A → 702.835 → 703.150
✅	agent_heroku_amd64	N/A	N/A → 310.148 → 314.260
✅	agent_msi	N/A	N/A → 608.990 → 624.040
✅	agent_rpm_amd64	N/A	N/A → 745.044 → 750.770
✅	agent_rpm_amd64_fips	N/A	N/A → 702.818 → 703.130
✅	agent_rpm_arm64	N/A	N/A → 722.622 → 724.500
✅	agent_rpm_arm64_fips	N/A	N/A → 683.566 → 684.870
✅	agent_suse_amd64	N/A	N/A → 745.044 → 750.770
✅	agent_suse_amd64_fips	N/A	N/A → 702.818 → 703.130
✅	agent_suse_arm64	N/A	N/A → 722.622 → 724.500
✅	agent_suse_arm64_fips	N/A	N/A → 683.566 → 684.870
✅	docker_agent_amd64	N/A	N/A → 805.206 → 806.340
✅	docker_agent_arm64	N/A	N/A → 807.597 → 810.120
✅	docker_agent_jmx_amd64	N/A	N/A → 996.126 → 997.060
✅	docker_agent_jmx_arm64	N/A	N/A → 987.296 → 989.800
✅	docker_cluster_agent_amd64	N/A	N/A → 206.895 → 207.710
✅	docker_cluster_agent_arm64	N/A	N/A → 220.888 → 221.210
✅	docker_cws_instrumentation_amd64	N/A	N/A → 7.154 → 7.190
✅	docker_cws_instrumentation_arm64	N/A	N/A → 6.689 → 6.920
✅	docker_dogstatsd_amd64	N/A	N/A → 39.472 → 39.560
✅	docker_dogstatsd_arm64	N/A	N/A → 37.690 → 38.080
✅	docker_host_profiler_amd64	N/A	N/A → 302.169 → 315.880
✅	docker_host_profiler_arm64	N/A	N/A → 313.664 → 327.470
✅	dogstatsd_deb_amd64	N/A	N/A → 30.127 → 30.790
✅	dogstatsd_deb_arm64	N/A	N/A → 28.252 → 29.290
✅	dogstatsd_rpm_amd64	N/A	N/A → 30.127 → 30.790
✅	dogstatsd_suse_amd64	N/A	N/A → 30.127 → 30.790
✅	iot_agent_deb_amd64	N/A	N/A → 44.472 → 45.230
✅	iot_agent_deb_arm64	N/A	N/A → 41.437 → 42.800
✅	iot_agent_deb_armhf	N/A	N/A → 42.146 → 42.960
✅	iot_agent_rpm_amd64	N/A	N/A → 44.472 → 45.230
✅	iot_agent_suse_amd64	N/A	N/A → 44.472 → 45.230

cit-pr-commenter-54b7da · 2026-05-07T13:25:25Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e84196df-9284-4de6-845b-d65053e2fa10

Baseline: 6345a30
Comparison: d85a724
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	-4.67	[-7.57, -1.77]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+0.88	[+0.70, +1.06]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.43	[+0.27, +0.59]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.40	[+0.37, +0.44]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_delta	memory utilization	+0.17	[-0.02, +0.36]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.16	[+0.11, +0.21]	1	Logs
➖	ddot_metrics	memory utilization	+0.13	[-0.07, +0.33]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.12	[-0.11, +0.36]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.39, +0.41]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.53, +0.55]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.11, +0.13]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.20, +0.21]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.01	[-0.45, +0.44]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.01	[-0.22, +0.20]	1	Logs
➖	ddot_logs	memory utilization	-0.02	[-0.09, +0.05]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.15, +0.10]	1	Logs
➖	file_tree	memory utilization	-0.03	[-0.07, +0.02]	1	Logs
➖	quality_gate_idle	memory utilization	-0.13	[-0.18, -0.08]	1	Logs bounds checks dashboard
➖	ddot_metrics_sum_cumulative	memory utilization	-0.16	[-0.32, -0.00]	1	Logs
➖	docker_containers_memory	memory utilization	-0.17	[-0.28, -0.06]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.41	[-1.41, +0.60]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	-0.64	[-0.75, -0.53]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-0.80	[-1.05, -0.56]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-4.67	[-7.57, -1.77]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	699 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	249.63MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	714 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	144.41MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	475.28MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	179.25MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	345.15 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	370.51MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Replaces github.com/gorilla/mux (and gorilla/handlers) with the standard library net/http across most of the agent's HTTP servers. Second step in the series to remove gorilla entirely — follow-up to #50275. Not included: cmd/system-probe (module router requires an API redesign) and comp/core/gui (auth middleware scoping needs a design decision). Key changes: - All servers migrated: agent CMD/IPC, cluster-agent, security-agent, process-agent, CLC runner, health probe, settings, status, fleet daemon, flare extensions - gorilla/handlers.RecoveryHandler replaced with pkg/api/middleware - Fleet daemon Content-Type gate converted to a middleware - Observability: WrapWithRouteTemplate and MountWithPrefix added to the observability package to preserve route-template metric tags - pkg/api/coverage.SetupCoverageHandler updated to accept *http.ServeMux; system-probe bridges via a local http.ServeMux until it migrates

…replace

…ig endpoint

…r branch cut

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63339f37d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…efix http.StripPrefix modifies r.URL.Path but not r.RequestURI. When a follower DCA forwards a request to the leader, the reverse proxy was sending the stripped path (e.g. /languagedetection) instead of the original full path (e.g. /api/v1/languagedetection). The leader's router mounts these endpoints under /api/v1/ so the forwarded request would 404. Affected endpoints: languagedetection, series (/api/v2), and cluster checks, all mounted via http.StripPrefix in the cluster-agent API server.

pgimalac added changelog/no-changelog No changelog entry needed team/agent-configuration labels May 5, 2026

dd-octo-sts Bot added internal Identify a non-fork PR team/container-platform The Container Platform Team team/agent-runtimes team/agent-build team/container-experiences team/agent-integrations labels May 5, 2026

github-actions Bot added the long review PR is complex, plan time to review it label May 5, 2026

dd-octo-sts Bot added team/agent-security team/profiling-full-host team/windows-products labels May 5, 2026

pgimalac force-pushed the pgimalac/gorilla-mux-pr12 branch 2 times, most recently from 3d9761e to dfd5a19 Compare May 6, 2026 14:00

github-actions Bot added the component/system-probe label May 6, 2026

dd-octo-sts Bot added the team/ebpf-platform label May 6, 2026

pgimalac force-pushed the pgimalac/gorilla-mux-pr12 branch from dfd5a19 to 6e58700 Compare May 7, 2026 12:37

pgimalac added the qa/done QA done before merge and regressions are covered by tests label May 7, 2026

pgimalac force-pushed the pgimalac/gorilla-mux-pr12 branch from b9891a8 to be305a7 Compare May 13, 2026 13:33

pgimalac marked this pull request as ready for review May 13, 2026 15:50

pgimalac requested review from a team as code owners May 13, 2026 15:50

dd-octo-sts Bot added team/agent-log-pipelines team/agent-devx team/cloud-network-monitoring team/agent-metric-pipelines team/container-integrations team/remote-config team/action-platform labels May 19, 2026

pgimalac added 6 commits May 19, 2026 08:50

fix: restore /api/v1/ in comment URLs wrongly stripped by search-and-…

596b119

…replace

fix: use {$} anchor for exact root match on config endpoint

bd7401b

chore: rebase onto main, re-tidy go.sum, fix exact root match on conf…

145df7b

…ig endpoint

fix: migrate InstallInstrumentationChecksEndpoints added to main afte…

f920541

…r branch cut

fix: restore start/command.go lost during bad conflict resolution

c0ed60b

pgimalac marked this pull request as draft May 19, 2026 08:50

chore: re-tidy go.sum after rebase

63339f3

pgimalac force-pushed the pgimalac/gorilla-mux-pr12 branch from 7b814f4 to 63339f3 Compare May 19, 2026 08:53

pgimalac removed request for a team, charan-manjunath and samrcarr May 19, 2026 08:54

pgimalac marked this pull request as ready for review May 19, 2026 08:56

AAraKKe approved these changes May 19, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 19, 2026

View reviewed changes

Comment thread cmd/cluster-agent/api/server.go

pgimalac added 2 commits May 19, 2026 09:12

Merge branch 'main' into pgimalac/gorilla-mux-pr12

50f1712

gh-worker-dd-mergequeue-cf854d Bot merged commit d85a724 into main May 19, 2026
471 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(api): replace gorilla/mux with net/http across agent servers#50380

refactor(api): replace gorilla/mux with net/http across agent servers#50380
gh-worker-dd-mergequeue-cf854d[bot] merged 9 commits into
mainfrom
pgimalac/gorilla-mux-pr12

pgimalac commented May 5, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented May 5, 2026 •

edited

Loading

Uh oh!

datadog-prod-us1-5 Bot commented May 5, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

Uh oh!

dd-octo-sts Bot commented May 6, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented May 6, 2026 •

edited

Loading

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented May 7, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Conversation

pgimalac commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Uh oh!

dd-octo-sts Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Go Package Import Differences

Uh oh!

datadog-prod-us1-5 Bot commented May 5, 2026 • edited by datadog-prod-us1-6 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

dd-octo-sts Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Files inventory check summary

Results for datadog-agent_7.81.0~devel.git.83.50f1712.pipeline.113925304-1_amd64.deb:

Uh oh!

dd-octo-sts Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Static quality checks

Info

Uh oh!

cit-pr-commenter-54b7da Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

pgimalac commented May 5, 2026 •

edited

Loading

dd-octo-sts Bot commented May 5, 2026 •

edited

Loading

datadog-prod-us1-5 Bot commented May 5, 2026 •

edited by datadog-prod-us1-6 Bot

Loading

dd-octo-sts Bot commented May 6, 2026 •

edited

Loading

dd-octo-sts Bot commented May 6, 2026 •

edited

Loading

cit-pr-commenter-54b7da Bot commented May 7, 2026 •

edited

Loading